From aa193ce4a4485ab37f703ea44e6342580a3d3eb6 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 6 Mar 2016 20:41:28 -0500 Subject: [PATCH] inspector: UI refresh The sidebar in the object page was using up more space than it deserves. Replace it with a combo box in the subheader. Now that we have more space, put the CSS node tree and the style properties in the same page again. --- gtk/inspector/Makefile.inc | 2 + gtk/inspector/actions.c | 9 - gtk/inspector/actions.ui | 9 - gtk/inspector/css-node-tree.c | 71 ------ gtk/inspector/css-node-tree.ui | 86 +------ gtk/inspector/gestures.c | 19 +- gtk/inspector/gtkstackcombo.c | 239 ++++++++++++++++++++ gtk/inspector/gtkstackcombo.h | 46 ++++ gtk/inspector/init.c | 2 + gtk/inspector/magnifier.c | 73 +++++- gtk/inspector/magnifier.ui | 41 ---- gtk/inspector/menu.c | 9 - gtk/inspector/menu.ui | 9 - gtk/inspector/misc-info.c | 7 - gtk/inspector/misc-info.ui | 10 +- gtk/inspector/object-hierarchy.c | 6 - gtk/inspector/object-hierarchy.ui | 13 +- gtk/inspector/prop-list.c | 44 ++-- gtk/inspector/prop-list.ui | 57 ----- gtk/inspector/selector.c | 6 - gtk/inspector/selector.ui | 12 +- gtk/inspector/signals-list.c | 94 ++++++-- gtk/inspector/signals-list.ui | 57 +---- gtk/inspector/size-groups.c | 13 +- gtk/inspector/window.c | 44 +++- gtk/inspector/window.h | 3 + gtk/inspector/window.ui | 362 ++++++++++++++++++++---------- 27 files changed, 766 insertions(+), 577 deletions(-) create mode 100644 gtk/inspector/gtkstackcombo.c create mode 100644 gtk/inspector/gtkstackcombo.h diff --git a/gtk/inspector/Makefile.inc b/gtk/inspector/Makefile.inc index e34a805a6c..7641d3a9e5 100644 --- a/gtk/inspector/Makefile.inc +++ b/gtk/inspector/Makefile.inc @@ -8,6 +8,7 @@ inspector_c_sources = \ inspector/general.c \ inspector/gestures.c \ inspector/graphdata.c \ + inspector/gtkstackcombo.c \ inspector/gtktreemodelcssnode.c \ inspector/init.c \ inspector/inspect-button.c \ @@ -38,6 +39,7 @@ inspector_h_sources = \ inspector/general.h \ inspector/gestures.h \ inspector/graphdata.h \ + inspector/gtkstackcombo.h \ inspector/gtktreemodelcssnode.h \ inspector/init.h \ inspector/magnifier.h \ diff --git a/gtk/inspector/actions.c b/gtk/inspector/actions.c index 4d7523a124..a3d0b0b807 100644 --- a/gtk/inspector/actions.c +++ b/gtk/inspector/actions.c @@ -44,7 +44,6 @@ struct _GtkInspectorActionsPrivate GtkListStore *model; GHashTable *groups; GHashTable *iters; - GtkWidget *object_title; }; G_DEFINE_TYPE_WITH_PRIVATE (GtkInspectorActions, gtk_inspector_actions, GTK_TYPE_BOX) @@ -231,13 +230,6 @@ gtk_inspector_actions_set_object (GtkInspectorActions *sl, g_free (prefixes); } } - - if (G_IS_OBJECT (object)) - { - const gchar *title; - title = (const gchar *)g_object_get_data (object, "gtk-inspector-object-title"); - gtk_label_set_label (GTK_LABEL (sl->priv->object_title), title); - } } static void @@ -286,7 +278,6 @@ gtk_inspector_actions_class_init (GtkInspectorActionsClass *klass) gtk_widget_class_set_template_from_resource (widget_class, "/org/gtk/libgtk/inspector/actions.ui"); gtk_widget_class_bind_template_child_private (widget_class, GtkInspectorActions, model); - gtk_widget_class_bind_template_child_private (widget_class, GtkInspectorActions, object_title); gtk_widget_class_bind_template_callback (widget_class, row_activated); } diff --git a/gtk/inspector/actions.ui b/gtk/inspector/actions.ui index 471a436f55..c87a06bac6 100644 --- a/gtk/inspector/actions.ui +++ b/gtk/inspector/actions.ui @@ -12,15 +12,6 @@